Clinic card screens #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs some work though.
…ycles' period days
Kept the range selection of days
Self screening
|
Can you share some few screens? |
Ogollah
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Are we still using static data? Kindly check. We want to do away with most of the static data files.
| @@ -328,7 +328,7 @@ class _ChatScreenState extends ConsumerState<ChatScreen> { | |||
| setState(() { | |||
| _consent = !_consent; | |||
| }); | |||
| _updateConsent(type == ConsentType.accept ? true : false); | |||
| _updateConsent(_consent); | |||
| Navigator.of(context).pop(); | |||
| }, | |||
| child: const Text('Yes'), | |||
There was a problem hiding this comment.
Can we have some of these texts as constatnts
There was a problem hiding this comment.
I think we are not using this file we can delete it.
Comment on lines
+52
to
+82
| final Map<String, String> svgMapping = { | ||
| "allergies": "assets/images/boldDuotoneMedicineVirus.svg", | ||
| "immunization": "assets/images/boldDuotoneMedicineSyringe.svg", | ||
| "conditions": "assets/images/boldDuotoneMedicineStethoscope.svg", | ||
| "labResults": "assets/images/boldDuotoneMedicineTestTube.svg", | ||
| "medications": "assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
| "procedures": "assets/images/boldDuotoneMedicineBone.svg", | ||
| "vitals": "assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
| }; | ||
|
|
||
| final List<String> items = [ | ||
| "Allergies", | ||
| "Conditions", | ||
| "Immunizations", | ||
| "Lab Results", | ||
| "Medications", | ||
| "Procedures", | ||
| "Vitals" | ||
| ]; | ||
|
|
||
| final List<String> icons = [ | ||
| // "assets/images/boldDuotoneFoldersFolderPathConnect.svg", | ||
| "assets/images/boldDuotoneMedicineVirus.svg", | ||
| "assets/images/boldDuotoneMedicineStethoscope.svg", | ||
| "assets/images/boldDuotoneMedicineSyringe.svg", | ||
| "assets/images/boldDuotoneMedicineTestTube.svg", | ||
| "assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
| "assets/images/boldDuotoneMedicineBone.svg", | ||
| "assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
| ]; | ||
|
|
There was a problem hiding this comment.
We need to think of a better way to present this.
Comment on lines
+52
to
+92
| final Map<String, String> svgMapping = { | ||
| "allergies": "assets/images/boldDuotoneMedicineVirus.svg", | ||
| "conditions": "assets/images/boldDuotoneMedicineStethoscope.svg", | ||
| "immunization": "assets/images/boldDuotoneMedicineSyringe.svg", | ||
| "labResults": "assets/images/boldDuotoneMedicineTestTube.svg", | ||
| "medications": "assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
| "procedures": "assets/images/boldDuotoneMedicineBone.svg", | ||
| "vitals": "assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
| }; | ||
|
|
||
| final List<String> items = [ | ||
| "Allergies", | ||
| "Conditions", | ||
| "Immunizations", | ||
| "Lab Results", | ||
| "Medications", | ||
| "Procedures", | ||
| "Vitals" | ||
| ]; | ||
|
|
||
| final List<String> icons = [ | ||
| "assets/images/boldDuotoneMedicineVirus.svg", | ||
| "assets/images/boldDuotoneMedicineStethoscope.svg", | ||
| "assets/images/boldDuotoneMedicineSyringe.svg", | ||
| "assets/images/boldDuotoneMedicineTestTube.svg", | ||
| "assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
| "assets/images/boldDuotoneMedicineBone.svg", | ||
| "assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
| ]; | ||
|
|
||
| final List<String> paths = [ | ||
| RouteNames.ALLERGY_HEALTH_RSHIP_RECORD, | ||
| RouteNames.HEALTH_RSHIP_RECORD, | ||
| RouteNames.IMMUNIZATION_RSHIP_RECORD, | ||
| RouteNames.LAB_RESULTS_HEALTH_RSHIP_RECORD, | ||
| RouteNames.MEDICATION_RSHIP_RECORD, | ||
| RouteNames.PROCEDURE_RSHIP_RECORD, | ||
| RouteNames.VITAL_HEALTH_RSHIP_RECORD, | ||
|
|
||
| ]; | ||
|
|
There was a problem hiding this comment.
We think on how to simplify this
| children: [ | ||
| _buildDateRow(record.visitDate, theme), | ||
| const SizedBox(height: Constants.SPACING), | ||
| _buildHospitalRow(record.facility, theme), |
There was a problem hiding this comment.
We were to remove the facility names from the cards.
There was a problem hiding this comment.
DependentClinicCard.mp4
Yeah, next pr will resolve this and screen_overflows
There was a problem hiding this comment.
Since we are merging to master don't you think we should just fix them in this PR?
There was a problem hiding this comment.
This can also work, so let me highlight the specific items to be resolve first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all screens for dependent's clinic-card